All pull requests

feat(atlas): land cosign + SBOM signatures for every release#2004

Openmiguel-arroyowants to merge 6 commits intomainfromfeat/atlas-3005
MIMiguel Arroyocommented 3w ago

Summary

feat(atlas): land cosign + SBOM signatures for every release — addresses the regression surfaced in atlas-edge after the recent feat work landed on main.

Why

  • The previous behavior on main short-circuited the safe path under load; this PR restores the intended contract.
  • Adds a guard so the regression cannot resurface silently in staging.
  • Drive-by: removes dead-code call sites the linter was warning about.

Scope

  • Files touched: 2 across the core module + tests.
  • No public API change; ABI is preserved.
  • CI: all green on the matrix runs.

Labels: refactor

MIMiguel Arroyocommented 2w ago

Rebased against main and force-pushed; CI is happy. Re-requesting review.

NONoor Hassancommented 1w ago

I think we can drop the legacy double-buffered drain once this lands — happy to do it as a follow-up.

NONoor Hassancommented 1w ago

LGTM modulo the comment I left on the changelog entry.

NONoor Hassancommented 1w ago

Smoke-tested under the load profile from last week's incident. No regressions.

NONoor Hassancommented 1w ago

Nice — pulled this locally and the burn-rate window now lines up with the SLO board. Approving once the snapshot tests catch up.

NONoor Hassancommented 1w ago

Could we add a regression test for the partial-bucket case? I'm happy to push it on top if you'd prefer.

All checks have passed1 neutral, 1 skipped, 3 successful checks
No conflicts with base branchMerging can be performed automatically.
You can also merge this with the command line. View command line instructions.Still in progress? Convert to draft

Add a comment

M↓Markdown is supported