All pull requests

build(harborlight): the dispatcher boundary#2006

Opensara-lindqvistwants to merge 7 commits intomainfrombuild/harborlight-3007
SASara Lindqvistcommented 3w ago

Summary

build(harborlight): the dispatcher boundary — addresses the regression surfaced in harborlight after the recent build work landed on main.

Why

  • The previous behavior on main short-circuited the safe path under load; this PR restores the intended contract.
  • Adds a guard so the regression cannot resurface silently in staging.
  • Drive-by: removes dead-code call sites the linter was warning about.

Scope

  • Files touched: 7 across the core module + tests.
  • No public API change; ABI is preserved.
  • CI: all green on the matrix runs.

Labels: security

SASara Lindqvistcommented 2w ago

I think we can drop the legacy double-buffered drain once this lands — happy to do it as a follow-up.

MIMiguel Arroyocommented 2w ago

LGTM modulo the comment I left on the changelog entry.

NONoor Hassancommented 2w ago

Smoke-tested under the load profile from last week's incident. No regressions.

MIMiguel Arroyocommented 2w ago

Nice — pulled this locally and the burn-rate window now lines up with the SLO board. Approving once the snapshot tests catch up.

NONoor Hassancommented 2w ago

Could we add a regression test for the partial-bucket case? I'm happy to push it on top if you'd prefer.

MIMiguel Arroyocommented 2w ago

Left a few small nits inline. Otherwise the shape is exactly what we discussed in the design doc.

All checks have passed1 neutral, 1 skipped, 5 successful checks
No conflicts with base branchMerging can be performed automatically.
You can also merge this with the command line. View command line instructions.Still in progress? Convert to draft

Add a comment

M↓Markdown is supported