All pull requests

feat(kernel): NURBS surface trimming with adaptive tessellation#88

Openleon-fischerwants to merge 3 commits intomainfromfeat/nurbs-trimming
LELeon Fischercommented 4d ago

Summary

feat(kernel): NURBS surface trimming with adaptive tessellation — addresses the regression surfaced in apothem after the recent feat work landed on main.

Why

  • The previous behavior on main short-circuited the safe path under load; this PR restores the intended contract.
  • Adds a guard so the regression cannot resurface silently in staging.
  • Drive-by: removes dead-code call sites the linter was warning about.

Scope

  • Files touched: 28 across the core module + tests.
  • No public API change; ABI is preserved.
  • CI: all green on the matrix runs.

Labels: feature

LELeon Fischercommented 2d ago

Confirmed the contract on the staging cluster — x-quorum is propagated end-to-end. Holding approval until I see the metric in Grafana.

YUYuki Tanakacommented 2d ago

Rebased against main and force-pushed; CI is happy. Re-requesting review.

AMAmara Oseicommented 2d ago

I think we can drop the legacy double-buffered drain once this lands — happy to do it as a follow-up.

YUYuki Tanakacommented 2d ago

LGTM modulo the comment I left on the changelog entry.

AMAmara Oseicommented 2d ago

Smoke-tested under the load profile from last week's incident. No regressions.

YUYuki Tanakacommented 2d ago

Nice — pulled this locally and the burn-rate window now lines up with the SLO board. Approving once the snapshot tests catch up.

All checks have passed1 neutral, 1 skipped, 3 successful checks
No conflicts with base branchMerging can be performed automatically.
You can also merge this with the command line. View command line instructions.Still in progress? Convert to draft

Add a comment

M↓Markdown is supported