All issues

Spec: define behavior of nested transactions on rollback#412

New issue
Open
LELeon Fischercommented 1w ago

Is your feature request related to a problem?

Spec: define behavior of nested transactions on rollback — today the workflow on millcreek requires an out-of-band step that breaks the editor flow and makes the API harder to type.

Describe the solution you'd like

Migrate the affected surface to follow the same contract as the rest of the toolchain, so composed flows stay consistent and predictable.

Describe alternatives you've considered

  • Keep the current implementation and document the seam.
  • Ship a codemod that rewrites call sites at install time.

However, both would still leave the surface on a different contract from the rest of the stack, and would only delay the cleanup.

Labels: question, documentation

LNln-dev7self-assigned this1w ago
LEleon-fischeradded the labelquestion1w ago
LNln-dev7added a commit that references this issuefix(millcreek): wire the new contract for #41203098261w ago
LNln-dev7mentioned this in#4591w ago
LNLNcommented 6d ago

Can confirm the repro on a clean checkout — the failing case is reliable on macOS 15.2 with Node 22.

LNLNcommented 6d ago

Pulled this locally, the workaround in the description is solid. Happy to land it as a follow-up.

LNLNcommented 5d ago

Could we add a regression test before the patch lands? Otherwise this will resurface as soon as the surrounding cleanup happens.

LNLNcommented 5d ago

Bumping priority — three customers hit this last week, two of them on the enterprise tier.

Add a comment

M↓Markdown is supported