All issues

Plugin manifest parser chokes on UTF-16 BOM#3019

New issue
Open
LNLNcommented 4w ago

Is your feature request related to a problem?

Plugin manifest parser chokes on UTF-16 BOM — today the workflow on delta-core requires an out-of-band step that breaks the editor flow and makes the API harder to type.

Describe the solution you'd like

Migrate the affected surface to follow the same contract as the rest of the toolchain, so composed flows stay consistent and predictable.

Describe alternatives you've considered

  • Keep the current implementation and document the seam.
  • Ship a codemod that rewrites call sites at install time.

However, both would still leave the surface on a different contract from the rest of the stack, and would only delay the cleanup.

Labels: refactor

LNln-dev7self-assigned this4w ago
LNln-dev7added the labelrefactor4w ago
LNln-dev7added this to the milestoneBacklog4w ago
LNln-dev7added a commit that references this issuefix(delta): wire the new contract for #30195ed45fb4w ago
LNln-dev7mentioned this in#30664w ago
LNLNcommented 2w ago

I've seen this too. I'll fix.

LNLNcommented 2w ago

Can confirm the repro on a clean checkout — the failing case is reliable on macOS 15.2 with Node 22.

LNLNcommented 2w ago

Pulled this locally, the workaround in the description is solid. Happy to land it as a follow-up.

LNLNcommented 2w ago

Could we add a regression test before the patch lands? Otherwise this will resurface as soon as the surrounding cleanup happens.

Add a comment

M↓Markdown is supported