All issues

Trace explainer should include rollup spans below 50µs#67

New issue
Open
ETEthan McAllistercommented 1w ago

Is your feature request related to a problem?

Trace explainer should include rollup spans below 50µs — today the workflow on sentinel-graph requires an out-of-band step that breaks the editor flow and makes the API harder to type.

Describe the solution you'd like

Migrate the affected surface to follow the same contract as the rest of the toolchain, so composed flows stay consistent and predictable.

Describe alternatives you've considered

  • Keep the current implementation and document the seam.
  • Ship a codemod that rewrites call sites at install time.

However, both would still leave the surface on a different contract from the rest of the stack, and would only delay the cleanup.

Labels: feature

ETethan-mcallisterself-assigned this1w ago
ETethan-mcallisteradded the labelfeature1w ago
ETethan-mcallisteradded a commit that references this issuefix(sentinel): wire the new contract for #6703094656d ago
ETethan-mcallistermentioned this in#1226d ago
ETEthan McAllistercommented 5d ago

I've seen this too. I'll fix.

ETEthan McAllistercommented 5d ago

Can confirm the repro on a clean checkout — the failing case is reliable on macOS 15.2 with Node 22.

ETEthan McAllistercommented 4d ago

Pulled this locally, the workaround in the description is solid. Happy to land it as a follow-up.

ETEthan McAllistercommented 4d ago

Could we add a regression test before the patch lands? Otherwise this will resurface as soon as the surrounding cleanup happens.

Add a comment

M↓Markdown is supported