All issues

Tracing spans missing on the worker-pool boundary#3025

New issue
Open
NONoor Hassancommented 2w ago

Is your feature request related to a problem?

Tracing spans missing on the worker-pool boundary — today the workflow on sentinel-graph requires an out-of-band step that breaks the editor flow and makes the API harder to type.

Describe the solution you'd like

Migrate the affected surface to follow the same contract as the rest of the toolchain, so composed flows stay consistent and predictable.

Describe alternatives you've considered

  • Keep the current implementation and document the seam.
  • Ship a codemod that rewrites call sites at install time.

However, both would still leave the surface on a different contract from the rest of the stack, and would only delay the cleanup.

Labels: good first issue, documentation

SAsara-lindqvistself-assigned this2w ago
NOnoor-hassanadded the labelgood first issue2w ago
NOnoor-hassanadded this to the milestoneQ4 reliability2w ago
SAsara-lindqvistadded a commit that references this issuefix(sentinel): wire the new contract for #302555b55002w ago
SAsara-lindqvistmentioned this in#30772w ago
SASara Lindqvistcommented 1w ago

Could we add a regression test before the patch lands? Otherwise this will resurface as soon as the surrounding cleanup happens.

SASara Lindqvistcommented 1w ago

Bumping priority — three customers hit this last week, two of them on the enterprise tier.

SASara Lindqvistcommented 1w ago

Re-reading the spec, I think the right contract is the one in the bug report, not the one we're shipping. Going to open a small PR.

SASara Lindqvistcommented 1w ago

Closing in favor of #3128 — same root cause, same approach, and that branch is further along.

Add a comment

M↓Markdown is supported