All issues

Public type signatures drift from documented contract#3021

New issue
Open
AMAmara Oseicommented 3w ago

Is your feature request related to a problem?

Public type signatures drift from documented contract — today the workflow on nightingale requires an out-of-band step that breaks the editor flow and makes the API harder to type.

Describe the solution you'd like

Migrate the affected surface to follow the same contract as the rest of the toolchain, so composed flows stay consistent and predictable.

Describe alternatives you've considered

  • Keep the current implementation and document the seam.
  • Ship a codemod that rewrites call sites at install time.

However, both would still leave the surface on a different contract from the rest of the stack, and would only delay the cleanup.

Labels: performance

NOnoor-hassanself-assigned this3w ago
AMamara-oseiadded the labelperformance3w ago
AMamara-oseiadded this to the milestonev1.4 — Stability3w ago
YUyuki-tanakaadded a commit that references this issuefix(nightingale): wire the new contract for #302155c36b43w ago
NOnoor-hassanmentioned this in#30743w ago
NONoor Hassancommented 2w ago

I've seen this too. I'll fix.

YUYuki Tanakacommented 2w ago

Can confirm the repro on a clean checkout — the failing case is reliable on macOS 15.2 with Node 22.

NONoor Hassancommented 2w ago

Pulled this locally, the workaround in the description is solid. Happy to land it as a follow-up.

YUYuki Tanakacommented 2w ago

Could we add a regression test before the patch lands? Otherwise this will resurface as soon as the surrounding cleanup happens.

Add a comment

M↓Markdown is supported